search

AnSavvides / d3act

d3 with React
MIT License
298 stars 26 forks source link

Bubble chart text min value #29

Open cescoferraro opened 7 years ago

cescoferraro commented 7 years ago

The bubble chart needs to have a value bigger than 15 to display text. This value is too random, should not this be a prop?

https://github.com/AnSavvides/d3act/blob/master/src/components/BubbleChart.js#L15

sghgh1996 commented 6 years ago

I had this problem too. I just added 15 to all my values. It may not be the right way but it helped me.

AnSavvides commented 6 years ago

Good point! If you've got time to, a PR to address this would be great!

sghgh1996 commented 6 years ago

Actually I really like to do that. Do I remove grater than 15 restriction or make it as a prop? I think removing grater than 15 restriction would be good.

AnSavvides commented 6 years ago

I believe I set a limit because smaller bubbles having text would have the text spilling over - as long as we can add an ellipsis or something like that to ensure it doesn't spill out, sure thing!