Open carmelorr opened 7 years ago
Talk with the board on this issue Required: @idanbarak @ronenru @OmKoren
@carmelorr the tools menu will be smaller (narrower) than the other menus on the sidebar and will include many other tools other than "image processing" (it is all ready include the "hover mouse" button). we cant use all of the menu to the manual image processing tools.
@eldadcohen1 Regarding the automatic image processing functions, I suggest that we start by implementing the simplest one: histogram equalization. Once we see it is doable - we can implement more sophisticated algorithms. Make sure to re-calculate it every time the pixels change (frustum, pan/zoom,...)
Here is a good explanation / implementation of histogram equalization in JS: http://phg1024.github.io/image/processing/2014/02/26/ImageProcJS4.html
@carmelorr I think that your design lacks the automatic image processing buttons.
Automatic processing-
Automatic processing will include- histogram, sharpness, (and gamma, brightness?)
One click on the icon (or toggle) will make a momentary processing (only observed area) Two clicks on the icon (or toggle) will make a constant processing.
Manual processing-
Manual processing will turn off the automatic processing (always?)
It will include- sharpness, histogram, gamma, brightness, saturation and contrast.
@carmelorr i think we dont need the expand/collapse buttons in the manual processing menu. we can expose all of the sliders permanently
@carmelorr add reset
@carmel i labeled it "ready for development" but please change gray divider to a bright option
@idanbarak
Please add tool tip- "Manual Image Enhancement"
@carmelorr i think we should consider some kind of visual representation (or preview) for the histogram slider. please see "picsplay" android app for inspiration
@carmelorr nice
As decided- at the moment the manual functions will cancel the auto ones and vise - versa. Also- please note that the manual enhancement functions will apply to each overlay (as opposed to imagery), and will not be saved. For later on- maybe save them per case?
image processing is divided to 3 levels:
histogram and fully automatic functions basic- automatic contrast and brightness basic manual functions- brightness, contrast, gamma and saturation