AnWeber / vscode-httpyac

Quickly and easily send REST, Soap, GraphQL, GRPC, MQTT and WebSocket requests directly within Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=anweber.vscode-httpyac
MIT License
237 stars 20 forks source link

http-client.env.json request_rejectUnauthorized not working in v5.10.3 #173

Closed koopssharp closed 1 year ago

koopssharp commented 1 year ago

Hi,

Great tool! I love it! I like to report a little defect in version v5.10.3.

In the last version v5.10.3 there is a defect. The request_rejectUnauthorized in not picked up from the http-client.env.json environment configuration.

For example:

 {
    "Local": {
        "request_rejectUnauthorized": false,
    }
 }

The setting is not picked up, and certificate chain validation is executed when executing the http request.

I currently use the v5.10.2 version, that is still working nicely.

AnWeber commented 1 year ago

It seems to work for me. The variable is used. But one problem was that the file is not valid JSON.

 {
    "Local": {
        "request_rejectUnauthorized": false
    }
 }
GET https://expired.badssl.com/

I added tests for this use case

AnWeber commented 1 year ago

I released a new version. Please test again and if it is not fixed reopen this issue. Thanks

koopssharp commented 1 year ago

@AnWeber : I just tested the new version 6.0.0. And the setting works as expected!

Thank you for the patch/fix!