search

AnWeber / vscode-httpyac

Quickly and easily send REST, Soap, GraphQL, GRPC, MQTT and WebSocket requests directly within Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=anweber.vscode-httpyac
MIT License
222 stars 20 forks source link

#265 breaks folding of json responses #269

Closed bohni closed 2 months ago

bohni commented 3 months ago

With Release 6.12.0 it is not possible anymore to fold JSON responses in output window

Try

GET https://httpbin.org/json
Accept: application/json

with 6.11.6 I get the folding marks on mouse hover: image

with 6.12.0 those marks don't appear. image

AnWeber commented 3 months ago

Every now and then I should read the docs in full. The standard behavior with indentation is deactivated by the custom FoldingRangeProvider. I have now created my own IndentationFoldingRangeProvider, which I use for the indented areas.

bohni commented 2 months ago

Hi,

unfortunately, the fix hasn't had the desired effect. Even with v6.12.1 I still can't see the markers.

AnWeber commented 2 months ago

@bohni Hello, it seems to work for me. Do you have an example or special settings?

image image
bohni commented 2 months ago

Hi, sorry for the noise... I tested on another setup and there I get those markers, too. Will check my faulty setup and repot back, if I found the reason. Thanks!

AnWeber commented 2 months ago

Do you use response output format exchange With this setting I found broken folding

bohni commented 2 months ago

Yes, you're right. I have responseViewContent set to exchange. Without that setting (using default) folding is working.

AnWeber commented 2 months ago

is fixed with this commit https://github.com/AnWeber/vscode-httpyac/commit/4977f82f830b550cf5b52acf690d643e1bf2bed7. I will release fix with next release