search

AnabelSMRuggiero / sbmltoodepy

A tool for creating Python implementations of SBML models.
BSD 3-Clause "New" or "Revised" License
13 stars 4 forks source link

JOSS reviewer 2 comment 2 #3

Closed marouenbg closed 5 years ago

marouenbg commented 5 years ago

Review openjournals/joss-reviews#1643

The package integrates a test suite to compare with COPASI results as a ground truth. If possible, you can consider continuous integration through a CI server like travis-ci. Recently, Github enabled CI, have a look here. CI would be a great addition to your package especially that you have the tests written and the model files in the repo. Alternatively, you can consider a code ocean capsule that includes entire OS with hardware for extended cross-compatiblity testing.

ashleefv commented 5 years ago

We are looked into the suggestion and are currently not interested in using Travis-CI. Travis-CI does not play well with PyPI accounts with non-alphanumeric characters in its password. Additionally, any updates to SBMLtoODEpy will change the code generated by it and may require different interfacing with user code. Because of this, we want only want a new version of our code pushed when we are absolutely certain its ready for public use. Building and pushing a new version of our code to PyPI is already a simple process with setuptools and twine.

We did set up a code ocean capsule and tested our code on Ubuntu 16.04 and 18.04. We're not planning on publishing the capsule as we do not believe it to be a good fit to publish this project on code ocean. However, we are glad the reviewer provided this suggestion because it may be a good fit for some of our other projects that involve simulation experiments.