search

AnacletoLAB / grape

🍇 GRAPE is a Rust/Python Graph Representation Learning library for Predictions and Evaluations
MIT License
502 stars 38 forks source link

typo: GraphVisualizer #23

Closed pnrobinson closed 1 year ago

pnrobinson commented 1 year ago

The image produced by GraphVisualizer has this

Degrees distribution of graph <graphname>

In English, one always uses the singular in phrases like this. Also, 'graph' seems superfluous. Suggested label:

Degree distribution of <graphname>
pnrobinson commented 1 year ago

The same problem occurs in the legend to the degree distribution plot

Node degrees distribution. Node degrees are on the horizontal axis and node counts are on the vertical axis on a logarithmic scale.

<Figure size 640x480 with 0 Axes>

Also, there is no reason to print the Figure size -- this seems to be coming from the library code.

pnrobinson commented 1 year ago

You might want to look through all methods and parameters for edges_ and change to edge_, there are a lot of mistakes like this, e.g. get_betweenness_centrality(edges_normalization=True).

LucaCappelletti94 commented 1 year ago

Hello Peter, the figure size is being printed by the Jupyter Notebook display. It is not something actively being printed by the grape library. I have resolved the "degrees distribution" -> "degree distribution" typo.

I will start to look into the edges ones.