search

AnacondaRecipes / aggregate

BSD 3-Clause "New" or "Revised" License
32 stars 43 forks source link

10-group migrations #269

Closed ryanskeith closed 1 year ago

ryanskeith commented 1 year ago

Migrating feedstocks in the 10-group from being root to having their own feedstocks.

Diffs were done using diff -rq aggregate/ migration/ on every feedstock. Here where each of the results:

gevent-websocket-feedstock: No differences found.

gfortran-feedstock: No differences found.

git-cola-feedstock: No differences found.

gptfdisk-feedstock: No differences found.

grako-feedstock: No differences found.

boldorider4 commented 1 year ago

OK, I reviewed the script you posted on slack. I suppose it looks good. The only part that confuses me is that I see this line:

!git submodule add -b main https://github.com/AnacondaRecipes/{dirname}

So this means that the repo for the migrated feedstock should already exist. And it should also be added to the .gitmodule file and the change should be visible in the PR since you do:

!gh pr create --title "{pr_title}" --body "{pr_body}"

So I'm still confused as to why the PR only shows removed files.

ryanskeith commented 1 year ago

@boldorider4 You are correct. Looking at my logs it seems there were consecutive git errors on migrations 7 - 11. I will need to fix them. I checked and all feedstocks were successfully created. I will not merge these 5 migrations. All 35 of these migrations were auto generated as there were a lot. I wanted to do them in small enough chunks that it would be obvious if errors occurred.

ryanskeith commented 1 year ago

@boldorider4 which repositories did you not find?