search

AnacondaRecipes / aggregate

BSD 3-Clause "New" or "Revised" License
32 stars 43 forks source link

cbc: set default to vs2019 #311

Closed cbouss closed 3 months ago

cbouss commented 3 months ago

Explanation of changes:

https://anaconda.atlassian.net/browse/PKG-4890 A lot of upstream projects now require a minimum of vs2019 for their build. This is to avoid having to override the cbc in feedstocks.

cbouss commented 3 months ago

LGTM. Can there be any drawbacks or pitfalls?

Not that I can see. Both depend on the same runtime in the end. But if there is, we'll be able to override back to vs2017 on our local cbc files as a workaround.

JeanChristopheMorinPerso commented 3 months ago

I saw some problem with cmake that wasn't able to find the right generator when using our vs2019 package, which indicates that we might have a problem with our vs2019 activation script. But I'm not too concerned by that. We should be able to see if it's a real problem or not pretty quickly.

cbouss commented 3 months ago

I saw some problem with cmake that wasn't able to find the right generator when using our vs2019 package, which indicates that we might have a problem with our vs2019 activation script. But I'm not too concerned by that. We should be able to see if it's a real problem or not pretty quickly.

Yes I have seen that too. Next time I come across it I'll look into fixing the activation script.