build against openssl 1.x, introduce new version

AnacondaRecipes / arrow-cpp-feedstock

A conda-smithy repository for arrow-cpp.

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

build against openssl 1.x, introduce new version #34

Closed M-Waszkiewicz-Anaconda closed 1 year ago

M-Waszkiewicz-Anaconda commented 1 year ago

introduce new 10.0.1+openssl1 version to be used by snowflake
remove python from cmake ( pure C/C++ build)
add openssl 1.1 to local conda_build_config.yaml
reset build number
use boost from global conda_build_config.yaml

skupr-anaconda commented 1 year ago

Generally, I understand the need to use openssl v1.1.1 but how the chain of dependencies will be consumed? Will all of them have +snowflake1 additional part of the package name? And then only if you install those package names explicitly you will have in your environment openssl v1.1.1 and it won't be overlapped by other packages with openssl v3.x.x? Is it correct?

Could you provide a comment about this chain in the meta.yaml AND local cbc.yaml to make it clear for our future selves?

M-Waszkiewicz-Anaconda commented 1 year ago

Generally, I understand the need to use openssl v1.1.1 but how the chain of dependencies will be consumed? Will all of them have +snowflake1 additional part of the package name? And then only if you install those package names explicitly you will have in your environment openssl v1.1.1 and it won't be overlapped by other packages with openssl v3.x.x? Is it correct?

Could you provide a comment about this chain in the meta.yaml AND local cbc.yaml to make it clear for our future selves?

All of them with openssl in a chain of dependency will have "+openssl1" in its version name and we will hold them in separate submodules until snowflake tell us it is no longer needed, so for example

snowflake_connector 3.2.0+openssl1 -> arrow_cpp 10.0.1+openssl1 -> openssl 1.x and at the same time: snowflake_connector 3.2.0 > arrow_cpp 10.0.1-> openssl 3.x

M-Waszkiewicz-Anaconda commented 1 year ago

LGTM but could you check the correct branches for packages from the dependency tree? Because there are placeholders .... And check if the submodule names and local folders from the aggregate repo are correct

done

skupr-anaconda commented 1 year ago

An error on osx-64: dyld[71382]: Library not loaded: @rpath/libzstd.1.dylib

If you reopen the PR it will succeed

M-Waszkiewicz-Anaconda commented 1 year ago

I think we need to do also pyarrow 10.0.1+openssl1 ?

skupr-anaconda commented 1 year ago

I think we need to do also pyarrow 10.0.1+openssl1 ?

Maybe, yes but it doesn't depend directly on openssl.

lorepirri commented 1 year ago

The last commit has all the checks green but the builds are not there for all platforms (s390x skipped) https://staging.continuum.io/prefect/fs/arrow-cpp-feedstock/pr34/878f03d

skupr-anaconda commented 1 year ago

We should name the version without + but like 10.0.1.openssl1 as we do for packages with versions like x.x.x.post1. Well, it's a field for discussion.

lorepirri commented 1 year ago

We should name the version without + but like 10.0.1.openssl1 as we do for packages with versions like x.x.x.post1. Well, it's a field for discussion.

It makes sense, as the + was already creating some issues with git / github