AnacondaRecipes / intel_repack-feedstock

Repackaging of Intel's MKL packages for usage in Anaconda

7 stars 5 forks source link

Main 2022.1.0 #15

Closed ScottBailey closed 2 years ago

ScottBailey commented 2 years ago

Changes

Update versions to latest.
Reorganize order to be OS specific.
Reduce missing_dso_whitespace entries using compilers in build sections.
Move global settings into specific outputs.
Add sha256 hashes.

Review Info

Source

Various

License

Proprietary

Jira

https://anaconda.atlassian.net/browse/DSNC-5191

AndrewVallette commented 2 years ago

The failures may be from low disk space and/or the other issues that the builders are currently experiencing. If this builds cleanly on another attempt, I would approve this.

I really like how the clarity of the recipe has been enhanced by the reorganization. The only thing I could nitpick is that some comments refer to missing_dso_whitespace instead of the correct missing_dso_whitelist.

ScottBailey commented 2 years ago

The only thing I could nitpick is that some comments refer to missing_dso_whitespace instead of the correct missing_dso_whitelist.

Corrected typos.