search

AnacondaRecipes / python-feedstock

A conda-smithy repository for python.
BSD 3-Clause "New" or "Revised" License
4 stars 7 forks source link

Update for release of Python 3.9.2 #26

Closed antkneed closed 3 years ago

antkneed commented 3 years ago

There seems to have been an update to this recipe recently and I wanted to ensure that this is the correct changes / route. I have two questions:

  1. Is this the correct branch for the python 3.9 line? It seemed like this build has not been released into defaults so I wanted to double check before moving forward with it. The prior seems to now be master-20210208.
  2. Does the vc on change make sense here or should it be removed from this local conda_build_config.yaml? It looks like these updates came in from Conda-Forge, but they are having a negative interaction within conda-build because we pin differently in our aggregate: 
    vc:
  - 14                         # [win]
  - 14                         # [win]
  - 14                         # [win]
  - 14                         # [win]

Note: this has been built and tested through our CI but I will hold off on uploading until this is reviewed.

mingwandroid commented 3 years ago

Hi @adipietro18.

It seemed like this build has not been released into defaults so I wanted to double check before moving forward with it. The prior seems to now be master-20210208.

I haven't had a chance to build it yet as I'm busy with other things, but the changes are trivial compared to the current release (we add -fno-semantic-interposition and a patch for macOS bigSur from conda-forge (so I rebased on top of their latest fairly recently)

aggregate's .gitmodules file gives the association between each folder (e.g. python-3.7-feedstock, python-3.8-feedstock and python-feedstock) and the branch that it tracks. Sometimes the tip of a branch will be ahead of what's been built, but it is hoped that the automated build system will pick those up, I guess.

mingwandroid commented 3 years ago

Thanks @adipietro18