NAV-917: conda constrained for old navigator releases

AnacondaRecipes / repodata-hotfixes

Changes to package metadata to fix behavior

BSD 3-Clause "New" or "Revised" License

14 stars 20 forks source link

NAV-917: conda constrained for old navigator releases #186

Closed yshmatov-anaconda closed 1 year ago

yshmatov-anaconda commented 1 year ago

Fixed issues:

anaconda-navigator<2.4.0 doesn't completely support conda>=23.1.0
anaconda-navigator<2.3.0 doesn't completely support pyqt>=5.15,<6.0a0
anaconda-navigator has issues with conda>=22.11.0,<23.1.0
anaconda-client<1.10.0 is incompatible with python 3.10

yshmatov-anaconda commented 1 year ago

Can we add unit tests to verify this has the correct behavior?

What do you want to check? If you are talking only about the updated replace_dep - then yes. But I also checked it when I created it to make sure it has no negative effects on what we already have.

If you are talking about the change to the repodata - I also checked the output of this change and it ended up with expected changes to all repodata files. Since we already know how it should affect everything - I believe it should be enough. Unless we want to double-check for repeated uses (I only designed the change with this in mind, but did not check this behavior; But it might also be checked right after this change is applied for the first time).

yshmatov-anaconda commented 1 year ago

I decided not to wait for answers and made few changes:

added tests, but also changed the behavior of the replace_dep function a little bit. If you provide multiple items to replace/remove - it would now affect all matching items instead of only the first one. This should not affect how the function is used currently, but otherwise it should help getting cleaner outputs in case data is already messed up.
rebased this PR to the latest master and rechecked that everything is still fine.
looked into adding tests for idempotency check, but only half-the way discovered that it is unnecessary since we always update the "raw" repodata instead of the "previously updated". However - I still found few places that required some cleanup. This change is not included in this PR, but if you are interested you may find it in this commit: ed86cb00cf7d925a2bb4cd1306999fb03b60ecde.

yshmatov-anaconda commented 1 year ago

Changed try-except with if-in-then as was requested.

And also checked again the output. For linux-64, noarch, osx-64, osx-arm64, win-64 - there are only expected changes mentioned in the description of this PR.