search

AnacondaRecipes / repodata-hotfixes

Changes to package metadata to fix behavior
BSD 3-Clause "New" or "Revised" License
14 stars 20 forks source link

add numpy 2 hotfix to main #227

Open JamesRobertsonGames opened 1 month ago

JamesRobertsonGames commented 1 month ago

numpy 2 pinnings for any packages that do not have an upper bound

Links

Explanation of changes:

Output from test-hotfix.py attached output.txt (Updated 14:14 | 19/06/24)

JamesRobertsonGames commented 4 weeks ago

@cbouss thanks for the review, made the suggestions and reuploaded the most upto date output

JamesRobertsonGames commented 4 weeks ago

Much better output now in the output.txt @cbouss

cbouss commented 3 weeks ago

Besides the diff it would be great to have some analysis on the repodata before and after the patch. I feel this would help ensure all is covered.

Also, I have been thinking, what if we publish this patch, then start building python packages with no upper bounds (because they support numpy 2), and someone regenerate a patch? A <1 bound would be wrongfully added. So perhaps instead we could have a configuration file like:

pandas: 2.2.2,
scikit-lear: 1.4.2,
...

Which could be used to patch like (pseudo code):

if pkg in numpy2_protect_dict:
  if VersionOrder(version) <= VersionOrder(numpy2_protect_dict['version']):
    add_dep(numpy < 2.0a0)

This way if needed we can tweak the configuration file and retain more control.