search

AnacondaRecipes / repodata-hotfixes

Changes to package metadata to fix behavior
BSD 3-Clause "New" or "Revised" License
14 stars 20 forks source link

Hypothesis hotfix exclusion #237

Closed JamesRobertsonGames closed 3 weeks ago

JamesRobertsonGames commented 3 weeks ago
JeanChristopheMorinPerso commented 3 weeks ago

@JamesRobertsonGames Why is the diff in the tests so big and full or R stuff?

JamesRobertsonGames commented 3 weeks ago

@JamesRobertsonGames Why is the diff in the tests so big and full or R stuff?

Not sure what this means @JeanChristopheMorinPerso ? There isn't a diff in tests or any relation to R stuff? The code changes are to reflect the oversights in the implementation of the protection dict which was untested at the time of deployment

JeanChristopheMorinPerso commented 3 weeks ago

The diff is in https://github.com/AnacondaRecipes/repodata-hotfixes/actions/runs/10457244044/job/28956421615?pr=237.

JamesRobertsonGames commented 3 weeks ago

Oh I see what you mean now. It seems to happen in all the PRs which is strange but uniform behaviour

https://github.com/AnacondaRecipes/repodata-hotfixes/actions/runs/10308588189/job/28536351183?pr=235#step:6:1603

My code doesn't actually currently impact the hotfix code at all and is not run at all, so we can be 100% confident this is normal behavior (to run the N2 hotfix it spits out a JSON file to be ingested to make the changes at bulk, this has not changed at all)

JamesRobertsonGames commented 3 weeks ago

@JeanChristopheMorinPerso just want to check your thoughts on the logs with this information inline?

Oh I see what you mean now. It seems to happen in all the PRs which is strange but uniform behaviour

https://github.com/AnacondaRecipes/repodata-hotfixes/actions/runs/10308588189/job/28536351183?pr=235#step:6:1603

My code doesn't actually currently impact the hotfix code at all and is not run at all, so we can be 100% confident this is normal behavior (to run the N2 hotfix it spits out a JSON file to be ingested to make the changes at bulk, this has not changed at all)

JamesRobertsonGames commented 3 weeks ago

JC approved verbally in a meeting so 2 approvals in