search

Anahkiasen / polyglot

Laravel localization and translation helper
130 stars 22 forks source link

Test code coverage #27

Closed jvdanilo closed 10 years ago

jvdanilo commented 10 years ago

Here is the 100% test code coverage.

Anahkiasen commented 10 years ago

Wow, thanks :o Why static test cases though ?

jvdanilo commented 10 years ago

I had some error with setUp method where you could run only one method and the next one even correct one would give an errror.

I know that I should no use static methods but I will try and correct that.

jvdanilo commented 10 years ago

Here it is without static.

jvdanilo commented 10 years ago

Here are the changes you requested, I hope i did everything right.

Anahkiasen commented 10 years ago

Oh, uh... actually I was talking about PSR2-tabs, so, the opposite :p I'm so sorry, if you don't feel like reverting I'll just merge this and try to get some time later to repass the files to tabs.

jvdanilo commented 10 years ago

Sory, I have commited the reverse now.

Anahkiasen commented 10 years ago

Allright looks perfect, thanks a lot for your contribution!