AnalogIO / analog-core

.NET 8 backend for Cafe Analog's coffee card app
https://core.prd.analogio.dk/swagger
MIT License
4 stars 1 forks source link

Allows setting product user groups #223

Closed A-Guldborg closed 11 months ago

A-Guldborg commented 12 months ago

This allows setting the product user groups when adding and updating products, including seeing products user groups.

This is necessary in order to manage products (enabling some products only to baristas etc.)

Front-end product management pull request for Shifty: https://github.com/AnalogIO/shifty-webapp/pull/20

codecov-commenter commented 12 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (a5c0c45) 7.90% compared to head (f4d2be6) 7.89%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #223 +/- ## ========================================== - Coverage 7.90% 7.89% -0.02% ========================================== Files 163 163 Lines 10129 10143 +14 Branches 461 461 ========================================== Hits 801 801 - Misses 9310 9324 +14 Partials 18 18 ``` | [Files](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [...ataTransferObjects/v2/Product/AddProductRequest.cs](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-Y29mZmVlY2FyZC9Db2ZmZWVDYXJkLk1vZGVscy9EYXRhVHJhbnNmZXJPYmplY3RzL3YyL1Byb2R1Y3QvQWRkUHJvZHVjdFJlcXVlc3QuY3M=) | `0.00% <ø> (ø)` | | | [...ansferObjects/v2/Product/ChangedProductResponse.cs](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-Y29mZmVlY2FyZC9Db2ZmZWVDYXJkLk1vZGVscy9EYXRhVHJhbnNmZXJPYmplY3RzL3YyL1Byb2R1Y3QvQ2hhbmdlZFByb2R1Y3RSZXNwb25zZS5jcw==) | `0.00% <0.00%> (ø)` | | | [...TransferObjects/v2/Product/UpdateProductRequest.cs](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-Y29mZmVlY2FyZC9Db2ZmZWVDYXJkLk1vZGVscy9EYXRhVHJhbnNmZXJPYmplY3RzL3YyL1Byb2R1Y3QvVXBkYXRlUHJvZHVjdFJlcXVlc3QuY3M=) | `0.00% <0.00%> (ø)` | | | [...DataTransferObjects/v2/Products/ProductResponse.cs](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-Y29mZmVlY2FyZC9Db2ZmZWVDYXJkLk1vZGVscy9EYXRhVHJhbnNmZXJPYmplY3RzL3YyL1Byb2R1Y3RzL1Byb2R1Y3RSZXNwb25zZS5jcw==) | `0.00% <0.00%> (ø)` | | | [...d/CoffeeCard.Library/Services/v2/ProductService.cs](https://app.codecov.io/gh/AnalogIO/analog-core/pull/223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-Y29mZmVlY2FyZC9Db2ZmZWVDYXJkLkxpYnJhcnkvU2VydmljZXMvdjIvUHJvZHVjdFNlcnZpY2UuY3M=) | `14.43% <0.00%> (-1.85%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghost commented 12 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/analog-core/223/ed4db194/abaa29464788360692c4678e53a6586f6598d521.svg)](https://app.codesee.io/r/reviews?pr=223&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fanalog-core) #### Legend CodeSee Map legend
jonasanker commented 12 months ago

Be aware that I'm cleaning up parts of the Products endpoints in #224

sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.4% 94.4% Coverage
7.6% 7.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint