AnalogIO / analog-core

.NET 8 backend for Cafe Analog's coffee card app
https://core.prd.analogio.dk/swagger
MIT License
4 stars 1 forks source link

Adds GET products/all for privileged users #237

Closed A-Guldborg closed 11 months ago

A-Guldborg commented 11 months ago

The API adds the endpoint GET /api/v2/products/all, which returns all products, regardless of usergroup or visibility.

This endpoint will be used for the product management frontend in https://github.com/AnalogIO/shifty-webapp/pull/20, discussed in https://github.com/AnalogIO/analog-core/issues/217 (and slack).

This endpoint is only accessible for users with Board privileges and will allow board members to manage the visibilty of products or products that they otherwise don't have access to themselves in the app.


Some weird merge conflicts arised on #232 after #234 was made. Probably due to me branching out from the wrong branch initially. Here is a new pull request instead :)

ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/analog-core/237/a85fbe83/871a862cc2306f52d2dab5f29f7eed4e4631f6b3.svg)](https://app.codesee.io/r/reviews?pr=237&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fanalog-core) #### Legend CodeSee Map legend
sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint