Adds menu items to products

AnalogIO / analog-core

.NET 8 backend for Cafe Analog's coffee card app

https://core.prd.analogio.dk/swagger

MIT License

4 stars 1 forks source link

Adds menu items to products #248

Closed marfavi closed 9 months ago

marfavi commented 9 months ago

A clip card can be valid for a range of concrete products (e.g. a cappuccino or a t-shirt). This PR enforces a ticket to specify what concrete product (called a menu item) it should be spent on, giving us much more precise statistics on ticket usage.

Endpoint changes:

New POST /v2/tickets/use/[ticketId]/[menuItemId] endpoint for using a ticket on a specific menu item
Changed all /v2/products endpoints to include a list of eligible menu items in their ProductResponse (the field is nullable for backwards compatability reasons).

ghost commented 9 months ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/analog-core/248/ee80389c/a595aed164051ad95e5c30fba7dadb2976b30ecd.svg)](https://app.codesee.io/r/reviews?pr=248&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fanalog-core) #### Legend CodeSee Map legend

A-Guldborg commented 9 months ago

Will the endpoint for managing these menu items and their relations with products be developed in another PR?

marfavi commented 9 months ago

Will the endpoint for managing these menu items and their relations with products be developed in another PR?

Yes, these are out of scope of this PR

sonarcloud[bot] commented 9 months ago

Quality Gate failed

Failed conditions

12.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud