Search returns single element that contains list

AnalogIO / analog-core

.NET 8 backend for Cafe Analog's coffee card app

https://core.prd.analogio.dk/swagger

MIT License

4 stars 1 forks source link

Search returns single element that contains list #249

Closed A-Guldborg closed 8 months ago

A-Guldborg commented 8 months ago

See below screenshot showing that the service returns a UserSearchResponse and not an enumerable.

This affects Shifty when we use the GenerateApi tool and the generated code expects to return a list.

A UserSearchResponse contains an enumerable of SimpleUserResponse and a TotalUsers (count) property.

ghost commented 8 months ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/analog-core/249/d91ccf91/4a0d43b1419d9cd68531714b8f3fefb3abeb5473.svg)](https://app.codesee.io/r/reviews?pr=249&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fanalog-core) #### Legend CodeSee Map legend

jonasanker commented 8 months ago

Good catch. Sorry for being too quick

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud