AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

refactor and test voucher #480

Closed fremartini closed 1 year ago

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/480/ecb90134/3831652d4becb390475d4f1ee63ffd7b70ebb979.svg)](https://app.codesee.io/r/reviews?pr=480&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 1 year ago

Codecov Report

Merging #480 (3831652) into develop (bae775e) will increase coverage by 1.39%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
+ Coverage    70.80%   72.19%   +1.39%     
===========================================
  Files          104      108       +4     
  Lines         1137     1158      +21     
===========================================
+ Hits           805      836      +31     
+ Misses         332      322      -10     
Flag Coverage Δ
unittests 72.19% <100.00%> (+1.39%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ures/voucher/domain/entities/redeemed_voucher.dart 100.00% <ø> (ø)
...ures/voucher/presentation/cubit/voucher_state.dart 100.00% <ø> (ø)
...r/data/datasources/voucher_remote_data_source.dart 80.00% <100.00%> (ø)
...es/voucher/data/models/redeemed_voucher_model.dart 100.00% <100.00%> (ø)
...s/voucher/domain/usecases/redeem_voucher_code.dart 100.00% <100.00%> (ø)
...ures/voucher/presentation/cubit/voucher_cubit.dart 100.00% <100.00%> (ø)
fremartini commented 1 year ago

@marfavi merged develop again. Can't Update Branch from here because merge conflicts