AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Refactor and test products #482

Closed fremartini closed 1 year ago

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/482/d12654c6/99f2158d7293c59516261bbdf9c55bf6651eb852.svg)](https://app.codesee.io/r/reviews?pr=482&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
fremartini commented 1 year ago

Currently broken because of Mockito not supporting record types. PR https://github.com/dart-lang/mockito/pull/645 should address this.

codecov[bot] commented 1 year ago

Codecov Report

Merging #482 (ee12b94) into develop (7505c32) will decrease coverage by 1.13%. The diff coverage is 47.05%.

:exclamation: Current head ee12b94 differs from pull request most recent head 99f2158. Consider uploading reports for the commit 99f2158 to get more accurate results

@@             Coverage Diff             @@
##           develop     #482      +/-   ##
===========================================
- Coverage    72.19%   71.07%   -1.13%     
===========================================
  Files          108      110       +2     
  Lines         1158     1165       +7     
===========================================
- Hits           836      828       -8     
- Misses         322      337      +15     
Flag Coverage Δ
unittests 71.07% <47.05%> (-1.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ures/product/domain/usecases/get_all_products.dart 0.00% <0.00%> (ø)
...ures/product/presentation/cubit/product_cubit.dart 0.00% <0.00%> (ø)
...es/purchase/presentation/cubit/purchase_cubit.dart 95.55% <ø> (ø)
lib/utils/firebase_analytics_event_logging.dart 0.00% <ø> (ø)
...ures/product/presentation/cubit/product_state.dart 20.00% <33.33%> (ø)
...t/data/datasources/product_remote_data_source.dart 100.00% <100.00%> (ø)
...ib/features/product/data/models/product_model.dart 100.00% <100.00%> (ø)
lib/features/product/domain/entities/product.dart 60.00% <100.00%> (ø)

... and 3 files with indirect coverage changes