AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

WIP: fix/refactor(purchase): fix support for "free product" purchases #487

Closed marfavi closed 1 year ago

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/487/24dcfcda/b94c318bc5e8a6f89d88e331607bdb8eec2af421.svg)](https://app.codesee.io/r/reviews?pr=487&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 1 year ago

Codecov Report

Merging #487 (bbdb623) into develop (b79b60e) will decrease coverage by 0.86%. The diff coverage is 78.12%.

:exclamation: Current head bbdb623 differs from pull request most recent head b94c318. Consider uploading reports for the commit b94c318 to get more accurate results

@@             Coverage Diff             @@
##           develop     #487      +/-   ##
===========================================
- Coverage    72.19%   71.34%   -0.86%     
===========================================
  Files          108      108              
  Lines         1158     1141      -17     
===========================================
- Hits           836      814      -22     
- Misses         322      327       +5     
Flag Coverage Δ
unittests 71.34% <78.12%> (-0.86%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ib/features/purchase/data/models/payment_type.dart 0.00% <0.00%> (ø)
...es/purchase/data/repositories/payment_handler.dart 10.00% <0.00%> (ø)
lib/features/purchase/domain/entities/payment.dart 94.73% <ø> (ø)
...tures/purchase/domain/entities/payment_status.dart 100.00% <ø> (+30.76%) :arrow_up:
.../data/datasources/purchase_remote_data_source.dart 63.63% <50.00%> (ø)
...b/features/purchase/data/models/payment_model.dart 100.00% <100.00%> (ø)
...rchase/data/repositories/free_product_service.dart 100.00% <100.00%> (ø)
.../purchase/data/repositories/mobilepay_service.dart 52.38% <100.00%> (-15.37%) :arrow_down:

... and 2 files with indirect coverage changes