AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

test: `secure_storage.dart` #494

Closed marfavi closed 1 year ago

ghost commented 1 year ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/494/3c9bb103/f352fed801372272103995b0416d46bedb68f527.svg)](https://app.codesee.io/r/reviews?pr=494&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.24% :tada:

Comparison is base (4aed248) 79.58% compared to head (f352fed) 81.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #494 +/- ## =========================================== + Coverage 79.58% 81.82% +2.24% =========================================== Files 114 114 Lines 1195 1194 -1 =========================================== + Hits 951 977 +26 + Misses 244 217 -27 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/494/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/494/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `81.82% <100.00%> (+2.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [lib/data/storage/secure\_storage.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2RhdGEvc3RvcmFnZS9zZWN1cmVfc3RvcmFnZS5kYXJ0) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marfavi commented 1 year ago

Re-ran test workflow on latest commit. Proper code coverage numbers are now reported