AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

replace Redeem Voucher with v2 endpoint #504

Closed fremartini closed 9 months ago

fremartini commented 10 months ago

closes #500

ghost commented 10 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/504/a141833b/e1dba2d91d339ce1d2174c2ad9efbe51cb254f47.svg)](https://app.codesee.io/r/reviews?pr=504&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 88.18% and project coverage change: +5.27% :tada:

Comparison is base (4aed248) 79.58% compared to head (e1dba2d) 84.85%. Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #504 +/- ## =========================================== + Coverage 79.58% 84.85% +5.27% =========================================== Files 114 114 Lines 1195 1195 =========================================== + Hits 951 1014 +63 + Misses 244 181 -63 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `84.85% <88.18%> (+5.27%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [...ening\_hours/domain/usecases/check\_open\_status.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZG9tYWluL3VzZWNhc2VzL2NoZWNrX29wZW5fc3RhdHVzLmRhcnQ=) | `100.00% <ø> (ø)` | | | [...\_hours/presentation/cubit/opening\_hours\_cubit.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvcHJlc2VudGF0aW9uL2N1Yml0L29wZW5pbmdfaG91cnNfY3ViaXQuZGFydA==) | `100.00% <ø> (ø)` | | | [...atures/register/domain/usecases/register\_user.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3JlZ2lzdGVyL2RvbWFpbi91c2VjYXNlcy9yZWdpc3Rlcl91c2VyLmRhcnQ=) | `80.00% <ø> (ø)` | | | [...user/domain/usecases/request\_account\_deletion.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3VzZXIvZG9tYWluL3VzZWNhc2VzL3JlcXVlc3RfYWNjb3VudF9kZWxldGlvbi5kYXJ0) | `100.00% <ø> (ø)` | | | [...user/data/datasources/user\_remote\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3VzZXIvZGF0YS9kYXRhc291cmNlcy91c2VyX3JlbW90ZV9kYXRhX3NvdXJjZS5kYXJ0) | `56.25% <53.33%> (-2.58%)` | :arrow_down: | | [.../data/datasources/purchase\_remote\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3B1cmNoYXNlL2RhdGEvZGF0YXNvdXJjZXMvcHVyY2hhc2VfcmVtb3RlX2RhdGFfc291cmNlLmRhcnQ=) | `75.00% <70.00%> (+11.36%)` | :arrow_up: | | [...r/data/datasources/voucher\_remote\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3ZvdWNoZXIvZGF0YS9kYXRhc291cmNlcy92b3VjaGVyX3JlbW90ZV9kYXRhX3NvdXJjZS5kYXJ0) | `83.33% <75.00%> (+3.33%)` | :arrow_up: | | [...e/data/datasources/account\_remote\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvZGF0YS9kYXRhc291cmNlcy9hY2NvdW50X3JlbW90ZV9kYXRhX3NvdXJjZS5kYXJ0) | `83.33% <81.25%> (+7.14%)` | :arrow_up: | | [...ta/datasources/leaderboard\_remote\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL2xlYWRlcmJvYXJkL2RhdGEvZGF0YXNvdXJjZXMvbGVhZGVyYm9hcmRfcmVtb3RlX2RhdGFfc291cmNlLmRhcnQ=) | `64.28% <85.71%> (+7.14%)` | :arrow_up: | | [lib/core/network/network\_request\_executor.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvbmV0d29yay9uZXR3b3JrX3JlcXVlc3RfZXhlY3V0b3IuZGFydA==) | `100.00% <100.00%> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/504/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.