AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Reintroduce opening hours #505

Closed fremartini closed 9 months ago

fremartini commented 9 months ago

closes #460

ghost commented 9 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/505/3bb2a14d/6c19a79b29eb65d5726f77bb819cb6662c0a9b8e.svg)](https://app.codesee.io/r/reviews?pr=505&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 9 months ago

Codecov Report

Patch coverage: 82.05% and project coverage change: -0.41% :warning:

Comparison is base (f32e93e) 84.85% compared to head (6c19a79) 84.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #505 +/- ## =========================================== - Coverage 84.85% 84.44% -0.41% =========================================== Files 114 115 +1 Lines 1195 1170 -25 =========================================== - Hits 1014 988 -26 - Misses 181 182 +1 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `84.44% <82.05%> (-0.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [lib/core/external/date\_service.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvZXh0ZXJuYWwvZGF0ZV9zZXJ2aWNlLmRhcnQ=) | `0.00% <0.00%> (ø)` | | | [...a/datasources/opening\_hours\_local\_data\_source.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZGF0YS9kYXRhc291cmNlcy9vcGVuaW5nX2hvdXJzX2xvY2FsX2RhdGFfc291cmNlLmRhcnQ=) | `0.00% <0.00%> (ø)` | | | [...s/opening\_hours/domain/entities/opening\_hours.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZG9tYWluL2VudGl0aWVzL29wZW5pbmdfaG91cnMuZGFydA==) | `100.00% <ø> (+66.66%)` | :arrow_up: | | [...atures/opening\_hours/domain/entities/timeslot.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZG9tYWluL2VudGl0aWVzL3RpbWVzbG90LmRhcnQ=) | `57.14% <57.14%> (ø)` | | | [...ta/repositories/opening\_hours\_repository\_impl.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZGF0YS9yZXBvc2l0b3JpZXMvb3BlbmluZ19ob3Vyc19yZXBvc2l0b3J5X2ltcGwuZGFydA==) | `100.00% <100.00%> (ø)` | | | [...ening\_hours/domain/usecases/check\_open\_status.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZG9tYWluL3VzZWNhc2VzL2NoZWNrX29wZW5fc3RhdHVzLmRhcnQ=) | `100.00% <100.00%> (ø)` | | | [...ening\_hours/domain/usecases/get\_opening\_hours.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvZG9tYWluL3VzZWNhc2VzL2dldF9vcGVuaW5nX2hvdXJzLmRhcnQ=) | `100.00% <100.00%> (ø)` | | | [...\_hours/presentation/cubit/opening\_hours\_cubit.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvcHJlc2VudGF0aW9uL2N1Yml0L29wZW5pbmdfaG91cnNfY3ViaXQuZGFydA==) | `100.00% <100.00%> (ø)` | | | [...\_hours/presentation/cubit/opening\_hours\_state.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL29wZW5pbmdfaG91cnMvcHJlc2VudGF0aW9uL2N1Yml0L29wZW5pbmdfaG91cnNfc3RhdGUuZGFydA==) | `71.42% <100.00%> (-28.58%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/505/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.