AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Consolidate receipt_overlay and loading_overlay #511

Closed fremartini closed 9 months ago

fremartini commented 9 months ago

closes #386

ghost commented 9 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/511/77828f20/f73d070c7bc82afca7510150116bccaa90115bb4.svg)](https://app.codesee.io/r/reviews?pr=511&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ad17be8) 74.22% compared to head (f73d070) 73.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #511 +/- ## =========================================== - Coverage 74.22% 73.93% -0.30% =========================================== Files 127 128 +1 Lines 1521 1527 +6 =========================================== Hits 1129 1129 - Misses 392 398 +6 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `73.93% <0.00%> (-0.30%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [...core/network/network\_request\_executor\_mapping.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvbmV0d29yay9uZXR3b3JrX3JlcXVlc3RfZXhlY3V0b3JfbWFwcGluZy5kYXJ0) | `100.00% <ø> (ø)` | | | [lib/core/strings.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvc3RyaW5ncy5kYXJ0) | `30.95% <0.00%> (-1.55%)` | :arrow_down: | | [lib/core/external/screen\_brightness.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/511?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2NvcmUvZXh0ZXJuYWwvc2NyZWVuX2JyaWdodG5lc3MuZGFydA==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.