Closed fremartini closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e680de1
) 73.93% compared to head (e77ca64
) 73.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@fremartini There has been a larger refactoring in #517 which you should take into account. It will probably give you a few bumps :)
Secondly. I would be mindful of not over-engineering with action files. I can see the value where several workflows have a need to call an action. In cases where an action is only called by one function, it might be just fine to have the steps in the workflow file :)
Thirdly, I am not sure but we should verify that Github Action supports parsing secrets as inputs such that we not leak secret values by accident when parsed as a input.
@fremartini Can you resolve the merge conflicts and then I'll provide my review :)
Closes #330