AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Appbundle #515

Closed fremartini closed 8 months ago

fremartini commented 8 months ago

Closes #330

ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/515/5e4a847c/e77ca6449f49544a560cdb4de19286ee39ed782a.svg)](https://app.codesee.io/r/reviews?pr=515&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e680de1) 73.93% compared to head (e77ca64) 73.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #515 +/- ## ======================================= Coverage 73.93% 73.93% ======================================= Files 128 128 Lines 1527 1527 ======================================= Hits 1129 1129 Misses 398 398 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/515/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/515/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `73.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasanker commented 8 months ago

@fremartini There has been a larger refactoring in #517 which you should take into account. It will probably give you a few bumps :)

Secondly. I would be mindful of not over-engineering with action files. I can see the value where several workflows have a need to call an action. In cases where an action is only called by one function, it might be just fine to have the steps in the workflow file :)

Thirdly, I am not sure but we should verify that Github Action supports parsing secrets as inputs such that we not leak secret values by accident when parsed as a input.

jonasanker commented 8 months ago

@fremartini Can you resolve the merge conflicts and then I'll provide my review :)