AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Fix email validation logic in Forgot Passcode page #521

Closed marfavi closed 8 months ago

marfavi commented 8 months ago

Inverted an if-else that would determine whether to show the "no account exists" error or not.

Fix #520

ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/521/126cf9b5/aafdc3bc64b7d755bcff58776cfa42d436bb8ed0.svg)](https://app.codesee.io/r/reviews?pr=521&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (a52acdb) 73.93% compared to head (aafdc3b) 73.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #521 +/- ## ======================================= Coverage 73.93% 73.93% ======================================= Files 128 128 Lines 1527 1527 ======================================= Hits 1129 1129 Misses 398 398 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/521/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/521/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `73.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.