Closed jonasanker closed 11 months ago
All modified lines are covered by tests :white_check_mark:
Comparison is base (
041b53d
) 73.93% compared to head (5802993
) 73.93%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
i think we should pin the version to avoid stuff breaking because of new versions.
I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.
Could we maybe just lock in in the minor version?
i think we should pin the version to avoid stuff breaking because of new versions.
I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.
Could we maybe just lock in in the minor version?
Minor versions would be fine. Expectations and reality have a tendency to not align
i think we should pin the version to avoid stuff breaking because of new versions.
I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches. Could we maybe just lock in in the minor version?
Minor versions would be fine. Expectations and reality have a tendency to not align
It seems you can not refer to a minor version. Only major versions or absolute versions are supported, thus I have changed all actions to refer their latest version.
@fremartini Please re-review
👇 Click on the image for a new way to code review
#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/522/08be70ab/58029933582280bbf9889175f8ad67402f55744d.svg)](https://app.codesee.io/r/reviews?pr=522&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend