AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Update Android SDKs, Java JDK and action versions to newer versions #522

Closed jonasanker closed 11 months ago

ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/522/08be70ab/58029933582280bbf9889175f8ad67402f55744d.svg)](https://app.codesee.io/r/reviews?pr=522&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (041b53d) 73.93% compared to head (5802993) 73.93%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #522 +/- ## ======================================= Coverage 73.93% 73.93% ======================================= Files 128 128 Lines 1527 1527 ======================================= Hits 1129 1129 Misses 398 398 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/522/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/522/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `73.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jonasanker commented 11 months ago

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.

Could we maybe just lock in in the minor version?

fremartini commented 11 months ago

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches.

Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

jonasanker commented 11 months ago

i think we should pin the version to avoid stuff breaking because of new versions.

I don't disagree as such. However we also be fine to lock into just the major or minor version as you wouldn't normally expect breaking behaviour between patches. Could we maybe just lock in in the minor version?

Minor versions would be fine. Expectations and reality have a tendency to not align

It seems you can not refer to a minor version. Only major versions or absolute versions are supported, thus I have changed all actions to refer their latest version.

@fremartini Please re-review