AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

refactor: load user info before main content flow #528

Closed marfavi closed 7 months ago

marfavi commented 8 months ago

This commit ensures that the user is loaded from the "splash router" before the home page is shown. This means everything below the "home page" widget will have access to a loaded user cubit state.

Extracted from #413 and therefore also a prerequesite for that PR.

ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/528/b8934854/a9b8eb8ac21770d4381733ce03ea69d00b1d7dbc.svg)](https://app.codesee.io/r/reviews?pr=528&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ba459b3) 73.93% compared to head (39f98ad) 74.18%.

:exclamation: Current head 39f98ad differs from pull request most recent head a9b8eb8. Consider uploading reports for the commit a9b8eb8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #528 +/- ## ========================================== + Coverage 73.93% 74.18% +0.24% ========================================== Files 128 128 Lines 1527 1534 +7 ========================================== + Hits 1129 1138 +9 + Misses 398 396 -2 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/528/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/528/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `74.18% <100.00%> (+0.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [...b/features/user/presentation/cubit/user\_cubit.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3VzZXIvcHJlc2VudGF0aW9uL2N1Yml0L3VzZXJfY3ViaXQuZGFydA==) | `72.97% <100.00%> (+3.27%)` | :arrow_up: | | [...b/features/user/presentation/cubit/user\_state.dart](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#diff-bGliL2ZlYXR1cmVzL3VzZXIvcHJlc2VudGF0aW9uL2N1Yml0L3VzZXJfc3RhdGUuZGFydA==) | `100.00% <100.00%> (+20.00%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.