search

AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

refactor: Option type and TimeOfDay in opening hours #544

Closed marfavi closed 7 months ago

marfavi commented 7 months ago

Uses the flutter-native TimeOfDay class, which has localized time formatting. This has been extended with comparison methods <= and isInTimeslot. Timeslot class simplifies with this change.

Simplify DateService to only contain one getter.

Make sure of fpdart's Option instead of null values. Use None for closed days.

Clean up tests and use NiceMocks for mocking.

ghost commented 7 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/544/9410c7c5/5d10511f15723c8040ef62adf17b2e4e70d01c5e.svg)](https://app.codesee.io/r/reviews?pr=544&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend