search

AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

(Test) Remove Firebase from the app #550

Open marfavi opened 7 months ago

marfavi commented 7 months ago

In an attempt to speed up iOS build speeds, Firebase has been completely removed from the project.

Relevant issue https://github.com/flutter/flutter/issues/37582

marfavi commented 7 months ago

The test results are in:

iOS build on this branch took 6m59s compared to 18m27s on other branches. This is a reduction of over 11 minutes(!)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (db0df6d) 72.85% compared to head (ec5f6c2) 71.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #550 +/- ## ========================================== - Coverage 72.85% 71.88% -0.98% ========================================== Files 130 129 -1 Lines 1573 1515 -58 ========================================== - Hits 1146 1089 -57 + Misses 427 426 -1 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/550/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/550/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `71.88% <100.00%> (-0.98%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TTA777 commented 7 months ago

Would be great if we could reduce pipeline time, but not sure if this is the right way to go. Have we tried the fix from https://github.com/firebase/flutterfire/issues/2751 ? Even if that doesn't fix it, wouldn't we still want the information that firebase is able to provide us, otherwise we are in the dark about issues happening in the app. If the aforementioned fix doesn't work, I'm all for looking at alternatives to firebase, perhaps something relying on openTelemetry, if dart has support for that by now 🤔