AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

Refactor authentication #552

Closed fremartini closed 7 months ago

ghost commented 7 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/552/abc00642/3edc963110c7f049d8a53319fe02cfd3ddd7ee3b.svg)](https://app.codesee.io/r/reviews?pr=552&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 7 months ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (db0df6d) 72.85% compared to head (3edc963) 72.70%.

Files Patch % Lines
...ation/domain/usecases/save_authenticated_user.dart 0.00% 4 Missing :warning:
...tion/domain/usecases/clear_authenticated_user.dart 0.00% 3 Missing :warning:
...cation/domain/usecases/get_authenticated_user.dart 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #552 +/- ## ========================================== - Coverage 72.85% 72.70% -0.15% ========================================== Files 130 134 +4 Lines 1573 1601 +28 ========================================== + Hits 1146 1164 +18 - Misses 427 437 +10 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/552/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/552/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `72.70% <86.66%> (-0.15%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.