AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

biometric authentication #556

Closed fremartini closed 1 week ago

ghost commented 11 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/556/a56c682a/62b2532c4e7134dfe91b160d95fb43e4c3a94492.svg)](https://app.codesee.io/r/reviews?pr=556&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 11 months ago

Codecov Report

Attention: Patch coverage is 62.90323% with 69 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (9db04b1) to head (62b2532). Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...biometric/domain/usecases/register_biometrics.dart 0.00% 15 Missing :warning:
...biometric/presentation/cubit/biometrics_cubit.dart 0.00% 15 Missing :warning:
.../data/datasources/biometric_local_data_source.dart 0.00% 11 Missing :warning:
...atures/biometric/data/models/user_credentials.dart 0.00% 9 Missing :warning:
...tion/presentation/cubits/authentication_cubit.dart 88.88% 4 Missing :warning:
...biometric/presentation/cubit/biometrics_state.dart 42.85% 4 Missing :warning:
...sion/presentation/cubit/session_timeout_state.dart 63.63% 4 Missing :warning:
...es/biometric/domain/usecases/clear_biometrics.dart 0.00% 3 Missing :warning:
...biometric/domain/usecases/get_registered_user.dart 0.00% 3 Missing :warning:
...res/session/data/models/session_details_model.dart 95.83% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #556 +/- ## ========================================== - Coverage 72.68% 71.54% -1.14% ========================================== Files 133 147 +14 Lines 1596 1775 +179 ========================================== + Hits 1160 1270 +110 - Misses 436 505 +69 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/556/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `71.54% <62.90%> (-1.14%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.