Closed marfavi closed 11 months ago
Attention: 22 lines
in your changes are missing coverage. Please review.
Comparison is base (
9db04b1
) 72.68% compared to head (5486555
) 72.36%.
Files | Patch % | Lines |
---|---|---|
lib/features/product/presentation/functions.dart | 0.00% | 18 Missing :warning: |
lib/core/strings.dart | 0.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
thats not really what i meant. The height is fine but i would like the 1.1 to be put into a variable called lineHeight
const lineHeight = 1.1; height = ....
Not sure how this improves things. The new const lineHeight = ...
line works like the line above it to minimize conditional logic in the return statement. If you mean something else, can you show a complete example?
thats not really what i meant. The height is fine but i would like the 1.1 to be put into a variable called lineHeight const lineHeight = 1.1; height = ....
Not sure how this improves things. The new
const lineHeight = ...
line works like the line above it to minimize conditional logic in the return statement. If you mean something else, can you show a complete example?
I pushed a commit now. I think its a code smell using a 'magic value' (1.1) in this case. This value could represent anything if you don't know its supposed to represent line height