AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

fix(ci): development version built in release pipeline #560

Closed marfavi closed 6 months ago

marfavi commented 6 months ago

This PR fixes the release pipeline bug that caused building a development version for release (in the first commit), and increases code robustness to prevent the same bug from appearing again (in the second commit).

The error was caused by a bug in actions code, which passed an ill-defined input variable (whether to build a dev/prod app) to another action. The input variable expected by the second action was optional, defaulting to build a dev version if no input variable is present.


Build configurations across Android and iOS build pipelines were updated to enforce the specification of 'development' or 'production' as mandatory build types. Introduced a shared 'verify_build_type' action that validates this input. This change ensures that artifacts are built against the correct backend environments and clarifies the pipeline behavior by removing ambiguity in build type selection. Additionally, updated steps to reflect the new build type validation and adjusted environment setup actions to accommodate the enforcement of build types.

Finally, this PR fixes the following yml syntax/schema errors:

ghost commented 6 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/560/fd643e22/2c57fc5cb355ff5a59a60e02ebba81ddb6a3ee0c.svg)](https://app.codesee.io/r/reviews?pr=560&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc0fa26) 72.36% compared to head (2c57fc5) 72.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #560 +/- ## ======================================= Coverage 72.36% 72.36% ======================================= Files 133 133 Lines 1603 1603 ======================================= Hits 1160 1160 Misses 443 443 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/560/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/560/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `72.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.