AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

chore(ci): migrate to firebase service account #562

Closed marfavi closed 6 months ago

marfavi commented 6 months ago

Closes #549

Replaced the deprecated FIREBASE_TOKEN with FIREBASE_SERVICE_ACCOUNT_JSON in the release-dev workflow to follow updated Firebase Distribution requirements. This change aligns with best practices and prepares for future Firebase Action updates.

Also streamlined the README documentation for GitHub Actions secrets by reformatting the table into a list with improved headings. This enhances readability, especially when editing the file, as whitespace are now removed.

ghost commented 6 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/562/e84ebe64/7b9dc345022dd32d6c9da267428b56c8f604c457.svg)](https://app.codesee.io/r/reviews?pr=562&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ed05b24) 72.36% compared to head (7b9dc34) 72.36%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #562 +/- ## ======================================= Coverage 72.36% 72.36% ======================================= Files 133 133 Lines 1603 1603 ======================================= Hits 1160 1160 Misses 443 443 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/562/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/562/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `72.36% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.