AnalogIO / coffeecard_app

Cross-platform coffee card app for Cafe Analog
https://www.cafeanalog.dk/app
MIT License
6 stars 1 forks source link

feat: adds Product selection when using ticket #567

Closed marfavi closed 8 months ago

marfavi commented 8 months ago

Add support for using concrete products when claiming a ticket:

other:

ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/AnalogIO/coffeecard_app/567/ffd141f5/658fb80df9f64b5188fe12f6b95345a3c2b5bea9.svg)](https://app.codesee.io/r/reviews?pr=567&src=https%3A%2F%2Fgithub.com%2FAnalogIO%2Fcoffeecard_app) #### Legend CodeSee Map legend
codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@242f176). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #567 +/- ## ======================================= Coverage ? 68.76% ======================================= Files ? 133 Lines ? 1697 Branches ? 0 ======================================= Hits ? 1167 Misses ? 530 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/567/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogIO/coffeecard_app/pull/567/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO) | `68.76% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=AnalogIO#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marfavi commented 8 months ago

There are frankly so many changes, I don't follow all of it.

With that said, only some smaller comments, where I would like some thoughts from you.

Also, are you sure that caching the last used menu item on swiping will have the intended outcome? I'm thinking that people will tend to be lazy, and just use whatever it was already on when swiping. This would be a shame, since it would basically make the data we get from it worthless. Is this something you have considered?

It was implemented to help people feel like not much extra work is being done. We can ask baristas about how precise customer swipes 1-2 weeks in with this feature enabled.