AnalogJ / lexicon

Manipulate DNS records on various DNS providers in a standardized way.
MIT License
1.48k stars 304 forks source link

Wrong requests requirement #1765

Closed jpiron closed 11 months ago

jpiron commented 11 months ago

Hi, Since the following commit e4db692cda2e3c677d7f61ee3d89e015a3ea5807, \ the requests requirement in pyproject.toml should be requests = ">=2.27.0" as the requests.exceptions.JSONDecodeError class has been added in this version (SEE: https://github.com/psf/requests/releases/tag/v2.27.0)

adferrand commented 11 months ago

This is quite relevant given the current code, but I would like to keep the widest possible compatibility with requests versions.

So instead I will import explicitly JSONDecodeError directly from simplejson or json.

Thanks !

adferrand commented 11 months ago

Version 3.16.1 is on its way.