[GoDaddy] Prevent invalid tts values and fix use subdomain

AnalogJ / lexicon

Manipulate DNS records on various DNS providers in a standardized way.

MIT License

1.48k stars 304 forks source link

[GoDaddy] Prevent invalid tts values and fix use subdomain #1834

Closed GiviMAD closed 1 month ago

GiviMAD commented 9 months ago

Hello, I'm using these project as part of Nginx Proxy Manager and I encountered some errors trying to run the DNS challenge for GoDaddy for a subdomain. I'm able to do it with the proposed changes.

Hope everything is ok I'm not too in touch with python.

Amazing project by the way :)

GiviMAD commented 9 months ago

I messed up with the second commit, I think now it's correct, let me know if there is something wrong there. I think the CI error is not due to my changes but I'm not sure if I'm right.

BR.

adferrand commented 1 month ago

All good to me, and sorry for the huge delay !