AnalogJ / scrutiny

Hard Drive S.M.A.R.T Monitoring, Historical Trends & Real World Failure Thresholds
MIT License
4.72k stars 154 forks source link

chore: use Linux container CPU quota #585

Open uhthomas opened 4 months ago

uhthomas commented 4 months ago

Go is not cgroup aware and by default will set GOMAXPROCS to the number of available threads, regardless of whether it is within the allocated quota. This behaviour causes high amount of CPU throttling and degraded application performance.

Fixes: #584

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.48%. Comparing base (0febe3f) to head (cc5b414). Report is 96 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #585 +/- ## ========================================== - Coverage 32.54% 31.48% -1.06% ========================================== Files 54 29 -25 Lines 3045 2763 -282 Branches 66 0 -66 ========================================== - Hits 991 870 -121 + Misses 2018 1854 -164 - Partials 36 39 +3 ``` | [Flag](https://app.codecov.io/gh/AnalogJ/scrutiny/pull/585/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogJ/scrutiny/pull/585/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga) | `31.48% <ø> (-1.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

uhthomas commented 4 months ago

I don't really understand what codecov is unhappy about - this commit is rebased on master.