search

AnalogJ / scrutiny

Hard Drive S.M.A.R.T Monitoring, Historical Trends & Real World Failure Thresholds
MIT License
4.72k stars 154 forks source link

rebase docker image to debian 12 (bookworm) #596

Closed dropsignal closed 3 months ago

dropsignal commented 3 months ago

docker image is now based on debian 12 bookworm so smartmontools is now 7.3. to resolve [BUG] Could not retrieve device information #538 https://github.com/AnalogJ/scrutiny/issues/538

dropsignal commented 3 months ago

I can make the necessary changes, but would that require a new pull request?

AnalogJ commented 3 months ago

Nope, no new pull request required. Just make changes in your existing branch, the PR will be updated.

AnalogJ commented 3 months ago

thanks!

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 31.48%. Comparing base (0febe3f) to head (6a9b89b). Report is 96 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #596 +/- ## ========================================== - Coverage 32.54% 31.48% -1.06% ========================================== Files 54 29 -25 Lines 3045 2763 -282 Branches 66 0 -66 ========================================== - Hits 991 870 -121 + Misses 2018 1854 -164 - Partials 36 39 +3 ``` | [Flag](https://app.codecov.io/gh/AnalogJ/scrutiny/pull/596/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/AnalogJ/scrutiny/pull/596/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga) | `31.48% <ø> (-1.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jason+Kulatunga#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.