AnalyticalGraphicsInc / gltf-vscode

This is an extension for Visual Studio Code to add support for editing glTF files.
Apache License 2.0
461 stars 63 forks source link

Option to disable the default hemisphere light? #210

Closed echadwick-artist closed 3 years ago

echadwick-artist commented 3 years ago

A hemisphere light is added to the Babylon.js preview by default. Could an option be added to the settings for glTF-Tools to disable the addition of this light?

Thanks!

image

bghgary commented 3 years ago

Unless there is also a hemisphere light in the other viewers, I recommend that we remove this light completely.

emackey commented 3 years ago

Yeah, different viewers have different lighting configurations. I guess we should unify them to all use the same setup. Maybe just the IBL by itself for all viewers? But there are some effects that show better under with a high-intensity light source present.

echadwick-artist commented 3 years ago

Agree, a strong punctual is often important. I'd prefer a directional light rather than a hemisphere. The latter acts more like a flat ambient light. The IBL does a much better job of providing ambient lighting.

It would help if the directional was optional, via Extension Settings. Perhaps also the angle and intensity could be controllable there, My default go-to angle for the key light is usually above and behind the camera's left shoulder, so we get specular/diffuse at upper left on the model, shading on the lower right.

echadwick-artist commented 3 years ago

:( This default light is quite an annoyance when editing material values, as I need to disable it each time I save the gltf, otherwise the model is blown out. It seems to overpower the sheen in Babylon.js. Can we please have a setting to disable it somehow?

gltf-tools_default-light