AnalyticalGraphicsInc / gltf-vscode

This is an extension for Visual Studio Code to add support for editing glTF files.
Apache License 2.0
460 stars 63 forks source link

Refinements on the outline provider #88

Closed najadojo closed 6 years ago

najadojo commented 6 years ago

Add an Asset tree at the top level that gives metrics about the glTF, including byte size and vertex counts. Refactor the skinned nodes so that they appear in the node tree as they do in the glTF, stop trying to decipher a skeleton when it coincides with a mesh.

emackey commented 6 years ago

This is awesome.

Any chance this could noticeably hurt performance with large models?

najadojo commented 6 years ago

Maybe... its a second walk over the glTF. The sizes are either just reading object attributes and a little math or they stat a file (images and buffer sizes from uri). I could probably combine the walks to create both trees at once but not sure that'd save much time.

emackey commented 6 years ago

I tried a few models and it seems fine. Maybe some model with thousands of meshes would have a problem, but such a model wouldn't render very efficiently either.