AnalyticalGraphicsInc / gltf-vscode

This is an extension for Visual Studio Code to add support for editing glTF files.
Apache License 2.0
460 stars 63 forks source link

Switch to use an encoded path for gltf-dataUri uris. #95

Closed najadojo closed 6 years ago

najadojo commented 6 years ago

A uri.authority part can be legally lowercased and then will no longer match actual filenames on case sensitive platforms. Also update client and server npm packages because they are initially mismatched (breaks on clean clones).

najadojo commented 6 years ago

I hesitate to use a separator that isn't something that segments a URI part already (i.e. $ is valid in a filename). Another option not use a separator but just concatenate and then to chomp up the path until it matches something open in the editor or is a file that stats and looks like glTF. That sounds like a lot of work so I stuck with what we had before.

emackey commented 6 years ago

Version 2.1.9 is published.