search

Anaminus / rbxmk

A tool for processing Roblox files.
MIT License
109 stars 11 forks source link

Colon character within a URL is detected as a drill separator #1

Closed Anaminus closed 7 years ago

Anaminus commented 7 years ago

In the http scheme, instances of a : character within the URL are detected as the drill separator, including URL-escaped instances. This will truncate the URL to that point, which may not be desirable. This should be fixed so that URL-escaped colons will not be detected as such, though normal colons still will be.

An exception to this is when a port is specified, which is detected correctly.

http://www.example.com:80/path/to/file:etc
                                      ^ first drill separator

This problem occurs because The url package is not flexible enough when it comes to raw, unescaped URLs. A modified version or new implementation of the package will be necessary.

Anaminus commented 7 years ago

The new system discards the idea of parsing single strings. Instead, each drill is a separate argument in a Lua function call.