Decoding a property that uses a reference doesn't check if the class is exactly the same.

Anaminus / rbxmk

A tool for processing Roblox files.

MIT License

109 stars 11 forks source link

Decoding a property that uses a reference doesn't check if the class is exactly the same. #54

Closed RaspyPiStyLiS closed 3 years ago

RaspyPiStyLiS commented 3 years ago

I've attached a PoC which contains a RopeConstraint with two attachment points and a rbxmk script to demonstrate the issue.

When loading this model into rbxmk the Attachment0 and Attachment1 properties on the RopeConstraint are discarded cause the ClassIsA check used to decode these properties only checks the parent class of the value.

Ref PoC.zip