search

Anandsg / Hungry-hero

The app is designed to be user-friendly, making it easy for people to discover, choose, and manage their favourite dining spots and food orders ⚡️
https://hungry-hero-ag.netlify.app/
MIT License
64 stars 101 forks source link

[Feature request] : Implement Dark Mode #134

Closed Anandsg closed 1 year ago

Anandsg commented 1 year ago

Problem: As of now, our application does not offer a dark mode option. Dark mode has become a popular feature, providing users with a visually pleasing and energy-efficient alternative to the default light mode.

Request: We would like to implement dark mode to enhance the user experience and give users the flexibility to choose their preferred mode.

Implementation Steps: To achieve dark mode, we'll need to:

Design Dark Mode UI: Create a visually appealing dark mode UI that complements our app's aesthetics.

Toggle Switch: Add a user-friendly toggle switch or button that allows users to switch between light and dark modes (in the header)

Adjust Colors: Modify the color schemes, text, and background colors to align with the dark mode design.

Accessibility: Ensure that the dark mode is accessible and maintains readability and usability for all users.

I'm searching for a developer who has practical experience in creating dark mode features.

Pinaka-Pani-18 commented 1 year ago

Hi @Anandsg, I can work on this issue.

MrSingh2000 commented 1 year ago

I would also like to contribute towards this issue.

Rahul-Roy-Hub commented 1 year ago

@Anandsg What happened in that code #124 ?

Anandsg commented 1 year ago

@Rahul-Roy-Hub That seems alright, but I didn't pay much attention to the other aspects like the empty cart image, shimmering UI, menu shimmer, contact page, about us section, footer, and the GitHub logo issue all these things needs to be covered. Also, in dark mode, users can't identify the header, and it causes conflicts. Although I've approved your PR since you did great work, these issues still need some attention. In the end, I'm starting to think that dark mode might not be the best fit for food ordering apps. Even Swiggy hasn't developed a dark mode because of these challenges. this user requested me to create a new issue so that he will address all of these concerns, so I went ahead and created it.

Rahul-Roy-Hub commented 1 year ago

@Anandsg Thanks for approved that PR. Yeah I know that all the issue occurs because if we use Dark Mode lots of changes are need and implement in components, So I think work later on that thing but it ok some one is doing. Let me know if other issue was there I will help on that assign me for it.

Anandsg commented 1 year ago

@Rahul-Roy-Hub Great, feel free to explore the app and request any issues or features you think we can work on. Keep in mind, this isn't for production use it's just a playground for us to showcase and level up our React skills so we can implement whatever feature we want.

Shamimayesmin commented 1 year ago

Hi @Anandsg , Can I work on this issue

Pinaka-Pani-18 commented 1 year ago

Hi @Anandsg, I have worked on this issue, but I don't know what went wrong. It is working correctly in my testing project. https://github.com/Anandsg/Hungry-hero/assets/102857774/4a001dac-1ffc-45f7-97a0-20f8a5967a81 But it is not working in our project. https://github.com/Anandsg/Hungry-hero/assets/102857774/66741767-231d-4bdb-9357-29f1f71eebf7 I apologize for not being able to complete this issue. I've tried my best. You can unassign me and assign it to someone else. I'm ready to work on a different issue.

Anandsg commented 1 year ago

Thanks for the update