Anant1902 / pe

0 stars 0 forks source link

Patients with the same phone numbers can be added #2

Open Anant1902 opened 2 months ago

Anant1902 commented 2 months ago

Description of Bug

Since NRIC is the only unique identifier for contacts, it is possible to create separate entries of patients with the same phone numbers (as shown in the screenshot below). Since each patient is a separate person with a separate NRIC, it is most likely that they will have different phone numbers. There can potentially be checks for duplicate phone numbers in the future too!

Steps to replicate

Add two patients using the addPatient/ap command with different NRICs but the same phone number - it is permitted. For example: ap i/S9876543A n/Betsy Crowe b/1998-02-03 t/Insulin e/betsycrowe@example.com a/Crowe street, block 234, #12-12 p/91234567 t/Paracetamol followed by ap i/S9876544A n/Betsy Crowe b/1998-02-03 t/Insulin e/betsycrowe@example.com a/Crowe street, block 234, #12-12 p/91234567 t/Paracetamol

Screenshot of bug

Screenshot 2024-04-19 at 4.29.46 PM.png

soc-pe-bot commented 2 months ago

Team's Response

Hello, thank you for raising this issue.

This was covered in the FAQ section of the UG:

image.png

The motivation is that we received feedback that there could be instances of elderly or children that may not have phone numbers. Therefore, the system is designed to allow duplicate phone numbers belonging to their next-of-kin to be filled instead! This will ensure that the clinic still retains methods to contact the patient in case of emergencies.

Hope this clarifies.

Response rejected.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]