AnantLabs / codesmith

Automatically exported from code.google.com/p/codesmith
1 stars 0 forks source link

CSLA Non entity.cst templates generate incorrect stored procedures. #316

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Opened Templates\Frameworks\Csla\VisualBasic\BusinessLayer\ReadOnlyList.cst
2. Selected a table and entered a custom business object name
3. Selected Stored Procedures.
4. Review the *.StoredProcedures.sql file generated.
5. If you also generate a manul ReadOnlyChild.cst the template inserts
*Info onto the name but the ReadonlyList/Criteria doesn't also implement
this same convention.

What is the expected output? What do you see instead?
A) The Business object specified in the template should generate the same
matching Stored procedure names.  This would ensure you can have ROL
generated independantly of the ERL BO's.
B) The stored procedures should match the BO generated. Eg. ROC should just
generate a select statement not all CRUD operations.
c) Entity.cst needs to insert the *Info name extension to the RO objects,
while manually running the ROL/Critiera/ROC templates allows you to follow
or ignore that naming convention.

What version of the product are you using?
v2.0.1.1481

Please provide any additional information below.
See attached image to see the SP's generated.

Original issue reported on code.google.com by JenasysD...@gmail.com on 17 Mar 2010 at 6:17

Attachments:

GoogleCodeExporter commented 9 years ago
Alternatively if you use Entity.cst to generate a single ROL/RO/Criteria there 
is a
bug in ReadOnlyList.Generated.cst, as it creates an Exist method that calls the 
wrong
BO. This is a problem if you haven't generated that BO to edit, which can 
happen when
your migrating an existing codebase to these templates.

    ' Generated
    Public Shared Function Exists(ByVal criteria As UserCriteria) As Boolean
        Return Iims.BL.User.Exists(criteria)
    End Function

    ' What should get generated.
    Public Shared Function Exists(ByVal criteria As UserCriteria) As Boolean
        Return Iims.BL.UserInfo.Exists(criteria)
    End Function

Original comment by JenasysD...@gmail.com on 17 Mar 2010 at 7:16

GoogleCodeExporter commented 9 years ago

Original comment by bniemyjski on 17 Mar 2010 at 1:10

GoogleCodeExporter commented 9 years ago

Original comment by bniemyjski on 19 Jun 2010 at 9:09

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r1780.

Issue 316:  CSLA Non entity.cst templates generate incorrect stored procedures.

Original comment by bniemyjski on 8 Jul 2010 at 5:22

GoogleCodeExporter commented 9 years ago
Hello,

I have fixed the naming issues and created two new feature requests for the 
unique stored procedure naming.

Thanks
-Blake Niemyjski

Original comment by bniemyjski on 8 Jul 2010 at 5:23

GoogleCodeExporter commented 9 years ago

Original comment by bniemyjski on 8 Jul 2010 at 5:23

GoogleCodeExporter commented 9 years ago
Would you add the links to these new cases please. Thanks.

Original comment by JenasysD...@gmail.com on 9 Jul 2010 at 2:56

GoogleCodeExporter commented 9 years ago

Original comment by bniemyjski on 15 Jul 2010 at 2:22